nccgroup / sobelow

Security-focused static analysis for the Phoenix Framework
Apache License 2.0
1.66k stars 92 forks source link

Plugin Mechanism #94

Open capitalist opened 3 years ago

capitalist commented 3 years ago

Is there an existing mechanism for, or plans for a plugin capability for custom Findings similar to credo's Check mechanism?

It looks like sobelow is already well architected to support this, but has the hard-coded @submodules

Forgive me if this is already asked & answered, but I did try to search, so the keywords I use will help others find the conversation if it has already been had.

GriffinMB commented 3 years ago

Hi! There wasn't (until now) any plan for it, but it's a good suggestion. I'll look into this. I'm working on some other things at the moment, so it might not be a quick turnaround.

I'll update this issue with details once I've worked out the details, and have an ETA.

capitalist commented 3 years ago

Wow, very quick reply. Fortunately, I don't need a quick turn around.

But we're working with a very smart offensive security expert who's suggested some very interesting things and we're looking at what our options are for tool extension.

GriffinMB commented 3 years ago

Sounds good! Also happy to accept Finding contributions if they're generally applicable :)

capitalist commented 3 years ago

I think we'd have a mix - some that are generally useful, and some that target specific patterns in our somewhat unorthodox platform.

houllette commented 1 year ago

Some inspiration could be taken from how Credo integrates plugins