Allow atom values for threshold in config file.

nccgroup / sobelow

Security-focused static analysis for the Phoenix Framework

Apache License 2.0

1.66k stars 92 forks source link

Allow atom values for threshold in config file. #96

Closed hassan closed 3 years ago

hassan commented 3 years ago

Assumes this is OK :-)

Addresses issue #95 (https://github.com/nccgroup/sobelow/issues/95)

GriffinMB commented 3 years ago

Excellent, thanks for the PR! Could you make the same update for line 216? Feel free to pull that functionality out into its own function.

hassan commented 3 years ago

Since those two examples have different case statements, it probably doesn't add a lot to try to split them out into a function (as much as I enjoy refactoring!)

Cheers 😀

GriffinMB commented 3 years ago

Sorry for the delayed merge, it's been a busy week! Thanks again for the PR :)

hassan commented 3 years ago

Thank you for the great tool. Glad to be able to contribute!