search

ncerny / chef_stack

4 stars 6 forks source link

Remove default value of `nil` #18

Closed brandocorp closed 7 years ago

brandocorp commented 7 years ago

The chef_backend_secrets property accepts a String object but defines a default value of nil. This change removes the default value, and uses :property_is_set? method to validate value

This fixes the deprecation warning seen when using the chef_server resource.

Deprecated features used!
         Default value nil is invalid for property chef_backend_secrets of resource chef_backend. Possible fixes: 1. Remove 'default: nil' if nil means 'undefined'. 2. Set a valid default value if there is a reasonable one. 3. Allow nil as a valid value of your property (for example, 'property :chef_backend_secrets, [ String, nil ], default: nil'). Error: Property chef_backend_secrets must be one of: String!  You passed nil. at 1 location:
           - /tmp/kitchen/cache/cookbooks/chef_stack/resources/backend.rb:30:in `class_from_file'
          See https://docs.chef.io/deprecations_custom_resource_cleanups.html for further details.
itmustbejj commented 7 years ago

👍