search

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.
Apache License 2.0
638 stars 116 forks source link

Fix the environment passed to subprocess calls when Flintrock is packaged with PyInstaller #172

Closed nchammas closed 7 years ago

nchammas commented 7 years ago

Fixes #158.

nchammas commented 7 years ago

@gnsiva - Can you let me know if this package fixes the issues you reported in #158?

Flintrock-0.8.0.dev0-standalone-Linux-x86_64.zip

gnsiva commented 7 years ago

The fix works, thanks very much! I'm glad you found such a clean fix, the stuff that came up on the PyInstaller bug report looked really awkward :+1:

nchammas commented 7 years ago

OK, I tweaked this PR slightly per my comment earlier. We may see slightly different behavior once the build runs on Travis CI, since the test package I posted here was built on a local Ubuntu VM.

Once we release Flintrock 0.8.0, @gnsiva let me know if you still see this issue and we can revisit it. For now I think it's been addressed.

gnsiva commented 7 years ago

The issue is fixed for me in the Flintrock 0.8.0 release as well