nchammas / flintrock

A command-line tool for launching Apache Spark clusters.
Apache License 2.0
637 stars 116 forks source link

Let the min root ebs size be configurable #191

Closed douglaz closed 7 years ago

douglaz commented 7 years ago

It was hard coded. Now it's configurable. This is useful for m4, r4, c4 machines without ephemeral disks.

Fixes #174.

nchammas commented 7 years ago

I initially resisted adding an option for this in #174, but with the additional detail here explaining why it would be useful I am convinced. (I edited a reference to #174 into the PR description btw.)

Tested this out with launch and add-slaves. Looks good to me.

Only thing missing is that the new option needs to be added to the config template. Add that in and I can merge this PR. 👍

nchammas commented 7 years ago

Never mind, I figured out how to push directly to your branch. Merging this in. Thanks!