search

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.
Apache License 2.0
637 stars 116 forks source link

User templates for hadoop / spark #202

Closed ncherel closed 4 years ago

ncherel commented 7 years ago

This PR makes the following changes:

I manually tested this PR. I started to run pytest but encountered errors not related to my changes. test_static are okay I will run the full test set once the general direction of this PR is approved.

I was thinking of adding a flintrock generate-templates /path/to/folder command to provide the base templates (those bundled with Flintrock). What do you think?

Fixes #200

nchammas commented 7 years ago

Hi @NCherel and thank you for this contribution to Flintrock! Sorry about the delay in reviewing it. I will try to take a detailed look through and give feedback by the end of this week.

I was thinking of adding a flintrock generate-templates /path/to/folder command to provide the base templates (those bundled with Flintrock). What do you think?

I would prefer not to add new commands and instead enhance flintrock configure to handle this. Perhaps we can duplicate the template tree into Flintrock's config directory (like we currently do for config.yaml) and that way users can simply find the templates with flintrock configure --locate and edit them as they please.

I'll have to think about this more, but that's my initial reaction.

nchammas commented 6 years ago

Hi @ncherel! Are you still interested in moving this PR forward? I think it's solid feature add to Flintrock, and if we resolve the issue with the manifest I'd be happy to merge it in. What do you think?

nchammas commented 4 years ago

Closing this PR due to inactivity. I might pick this idea up later because I think it's really good!