Add support for slave groups

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.

Apache License 2.0

637 stars 116 forks source link

Add support for slave groups #209

Closed ktdrv closed 6 years ago

ktdrv commented 7 years ago

This PR makes the following change:

Adds support for slave groups, which allow the user to tag instances created with add-slaves and launch and reference those tags later when calling remove-slaves.

This is an improvement over the current behavior, which follows a simple LIFO methodology, prioritizing spot instances.

I tested this PR by manually testing it over a range of input sequences. Could not run the test suite.

nchammas commented 7 years ago

Hi @ktdrv! Thank you for this contribution and sorry about the delay in reviewing it.

Can you elaborate a bit on the motivation for this change? On first blush it doesn't seem worth the (minor) added complexity since the current behavior of deleting spot instances first seems like it covers typical use cases very well.

nchammas commented 6 years ago

I'm going to close this, but if you want to continue the discussion, please do!