search

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.
Apache License 2.0
636 stars 116 forks source link

Mention Homebrew install instructions #242

Closed tdsmith closed 6 years ago

tdsmith commented 6 years ago

Hi; thanks for flintrock! I packaged flintrock for Homebrew if you'd like to mention it in the readme. The advantage of installing with Homebrew is that it keeps flintrock and its dependencies in its own private virtualenv, and users can get new versions when they run brew upgrade.

nchammas commented 6 years ago

Hi @tdsmith and thank you for adding Flintrock to Homebrew. I guess this is where it happened: https://github.com/Homebrew/homebrew-core/pull/25025 👍

I'm not interested in maintaining a Flintrock package for Homebrew at this time, so my concern about adding this to the README is that it "blesses" the Homebrew package as an official installation method. If the Homebrew package is not kept up to date, it will lead to some confusion and I will perhaps get some of the blame.

That said, I wouldn't mind mentioning it in the README as long as it's clear that the Homebrew package is community-maintained and that users wanting to be sure they are getting the latest version should instead stick with pip.

tdsmith commented 6 years ago

That makes sense! Thanks for your quick feedback. I tried to address your concern by adding a separate section for community-supported distributions; what do you think?

nchammas commented 6 years ago

Looks good to me. I'll merge this in and make some edits for wording.

Thanks again!