search

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.
Apache License 2.0
636 stars 116 forks source link

Test for get_latest_commit() is flaky on Travis CI #247

Closed nchammas closed 3 years ago

nchammas commented 6 years ago

I'd guess it's because GitHub is rate-limiting requests from Travis. We'll need to either skip the test or somehow configure Travis to use a GitHub API token so that GitHub doesn't reject our requests.

nchammas commented 3 years ago

Not sure is this is still a problem. The test itself has the appropriate pytest mark, so I don't think we need to track this issue here as well.

https://github.com/nchammas/flintrock/blob/e03748582c279dc000578fe8898a6be60dc34b84/tests/test_flintrock.py#L136-L141