[#271] Properly handle multiple client IP addresses

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.

Apache License 2.0

636 stars 116 forks source link

[#271] Properly handle multiple client IP addresses #272

Closed boechat107 closed 5 years ago

boechat107 commented 5 years ago

This PR makes the following changes:

it adds a call to split(',') from the string returned by AWS "checkip".

I tested this PR by adding a unit test for the function responsible for making the HTTP request to "checkip". The acceptance tests were not executed.

Fixes #271

boechat107 commented 5 years ago

Thanks, @nchammas. I've also learned from your code in the past. Flintrock was the first project I saw using type annotations for Python, I didn't know they even existed.

I agree with your precautions, specially about the order of the IPs.

In addition, I'd like to thank you for this great project. It has been very useful for my team.

boechat107 commented 5 years ago

@nchammas, I'm closing this PR in favor of #277, which just replaces the protocol.