search

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.
Apache License 2.0
636 stars 116 forks source link

Properly decode UserData before adding to new slaves #304

Closed nchammas closed 4 years ago

nchammas commented 4 years ago

I tested this PR by adding slaves to an existing cluster and confirming that the UserData attribute is not gibberish.

Fixes #303.

nchammas commented 4 years ago

@dhorgan - Test this out and let me know if it fixes the problem for you.

I'm curious to know also if you have any issues with UserData when using spot instances.

dhorgan commented 4 years ago

I've just tested this and I can confirm that it's working now! 👍

dhorgan commented 4 years ago

I'm curious to know also if you have any issues with UserData when using spot instances.

Sorry, I can't help here - we aren't using spot instances right now.

nchammas commented 4 years ago

No worries. Thanks for confirming on your end.

I tested out spot instances just now, and adding a spot slave preserves the UserData attribute correctly.

Merging this in.