Hadoop 3.x port changes (#306)

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.

Apache License 2.0

637 stars 116 forks source link

Hadoop 3.x port changes (#306) #307

Closed sfcoy closed 4 years ago

sfcoy commented 4 years ago

This PR makes the following changes:

Migrate SecurityGroupRules provisioning to their respective FlintrockService classes (as per the TODO in the source)
Use the HDFS version to select the name node ui port number

I tested this PR by creating and launching the following combinations of Spark and Hadoop:

Spark 2.4.5, Hadoop 2.8.5
Spark 3.0.0rc1. Hadoop 3.2.1

Fixes #306

nchammas commented 4 years ago

Hello @sfcoy and thank you for this PR. I still have this on my list to review. Sorry about the slow turnaround time! I will get back to you in the next week or so.

sfcoy commented 4 years ago

Mate, how could I possibly mind? It's your baby and we are grateful to have access to it.

nchammas commented 4 years ago

Thank you. I am likewise grateful to have positive users and helpful and empathetic contributors like yourself.