nchammas / flintrock

A command-line tool for launching Apache Spark clusters.
Apache License 2.0
636 stars 116 forks source link

Add changelog entry #312

Closed matthewfranglen closed 3 years ago

matthewfranglen commented 4 years ago

Relates to https://github.com/nchammas/flintrock/pull/311

This is the changelog for that PR.

nchammas commented 4 years ago

Thanks for submitting this PR, @matthewfranglen. Most contributors don't think to add a change log for their PRs!

Generally speaking, I like to write change logs myself since I can summarize changes and place them in the appropriate context as maintainer.

If you'd like to try polishing this change log entry up, then what I'd suggest is:

But don't feel obliged to do this! As I said, I prefer to write change logs myself. But since you demonstrated interest, I thought I'd lay out what I would do if I were writing this change log.

matthewfranglen commented 4 years ago

I've made the changes you have suggested. I understand your desire to write your own changelog so feel free to close this.

nchammas commented 3 years ago

Looks good to me. Thanks for the update! I will push a few minor edits to your branch, if you don't mind, and merge this in this weekend.