Closed rlaabs closed 3 years ago
Thanks for the report. I guess the problem is in the repeated calls to ec2.Subnet()
:
I believe @luhhujbb warned that this would happen. I think a fix worth exploring would be to decorate private_network()
with @lru_cache
. (There are newer alternatives available like @cached_property
, but that requires Python 3.8+. Flintrock currently supports 3.6+.)
Hi, it seems that @cached_property
is compatible with python 3.6 : cached-property
That's neat. I would prefer to stick to the standard library, but if there is a problem combining @property
with @lru_cache
then cached-property
would be a good way to go.
@nchammas It's seems Ok for the combination of @property
and @functools.lru_cache
cf : https://stackoverflow.com/questions/4037481/caching-class-attributes-in-python
When launching a cluster (tried m5 and r4 instances) with about more than 20 instances the following error is raised:
botocore.exceptions.ClientError: An error occurred (RequestLimitExceeded) when calling the DescribeSubnets operation (reached max retries: 4): Request limit exceeded.
From the traceback it looks like this may be caused by the changes in #296 ?
-->
Traceback: