Fixed centralize logic TODOs in ec2 - Githubissues

nchammas / flintrock

A command-line tool for launching Apache Spark clusters.

Apache License 2.0

636 stars 116 forks source link

Fixed centralize logic TODOs in ec2 #378

Open tomahawk360 opened 1 month ago

tomahawk360 commented 1 month ago

This PR makes the following changes:

Replaced three security_groups.filter() instances at lines 180, 197 and 379, each marked with a "Centralize logic..." TODO comment, with get_security_groups() function.
Removed "Centralize logic..." TODO comments in all previously mentioned instances.

I tested this PR by:

Launching a cluster
Adding slaves
Removing slaves
Destroying a cluster
Running "pytest" command