search

nchaulet / node-geocoder

nodejs geocoding library
http://nchaulet.github.io/node-geocoder/
MIT License
930 stars 214 forks source link

Added an additional here geocoder which provides suggestions to given… #210

Open ccaliskan opened 7 years ago

ccaliskan commented 7 years ago

Here geocoder gave very unsatisfying suggestions to my address searches. So i added an intermediate step, that calls the suggestions API of Here. The given suggestions are then being geocoded by their location ids.

nchaulet commented 7 years ago

I am not sure that is the best way to do it maybe we can extends the existing Here geocoder to do that and not create a new one.

Do you know if suggestion is something that other geocoding API provide ? google ? ...

Thanks and I will be happy to help you with this problem.

ccaliskan commented 7 years ago

Thanks for your reply.

The reason for a new geocoder was to touch as little existing code as possible. But if you think it is better to extend the existing one, i'm perfectly ok with it. How would you do it? With a flag (suggestions on/off) or with a new function?

I had a look at Google, they provide suggestions via their Places API (autocomplete, they call it). TomTom has a fuzzy search with a typeahead query parameter, which seems to do the same job. OSM does not provide suggestions. Unfortunately i have no other experience with geocoding other than Here maps.

nchaulet commented 2 years ago

run integrations test