Closed charly22 closed 2 years ago
@nchaulet I'm sure that looking into this it isn't among your top priorities, I'm wondering if you have had a chance to look at this because I'm planning to add this very same support for Here sooner than later and these changes depend on this PR. Thanks!
Hi @charly22 I took a first look at this and it looks good to me, I still want to run it locally too, I have one suggestion that I would love you to address.
What does this PR do?
Changes the strategy used to geocoding in batch using async batch TomTom API
Brief of changes
AbstractGeocoder
calls_batchGeocode
of the provider who has this implemented or throws an error if it doesn't.Geocoder
callbatchGeocode
catching thenot implemented
error to fallback to the pool-of-promises legacy strategyTomTomGeocoder
implements_batchGeocode
calling the TomTom Batch APIs to 1. Create a job, 2. Poll the job status 3. Download the results when it's donelimit
andcountry
parameters forTomTom
(see TODOs)Additionally
FetchAdapter
to allow the return of the full response in order to check status codes, batch API it's not as simple as getting JSON results,POST
support toFetchAdaptar
(I haven't done for the rest of the adapter, but I believe they're deprecated, I'm I right)querystring
deprecated dependency onFetchAdapter
TODOs
README.md
with new TomTom parameters @nchaulet I'd appreciate your help here. Thanks :)