Propagate country param to TomTom geocoder

nchaulet / node-geocoder

nodejs geocoding library

http://nchaulet.github.io/node-geocoder/

MIT License

926 stars 213 forks source link

Propagate country param to TomTom geocoder #330

Closed amiedes closed 2 years ago

amiedes commented 2 years ago

What does this PR do?

If country was passed as an option when instantiating the geocoder, it will be propagated to the TomTom API as the countrySet argument.

Decisions taken

The TomTom API countrySet parameter really accepts a comma-separated list of Alpha2 coudes (ES,AU,US), but for simplicity and to avoid maintaining redundant validations (the TomTom API will already be validating the format of this) we decided just to propagate the value as it is received.

amiedes commented 2 years ago

Hi @nchaulet 👋, I'm a colleage of @charly22 from CARTO.

Sorry for bombarding you with a myriad of PRs all of a sudden 😅, but if you managed to find some time to review this during the next days/week we'd be very pleased 🙇.

Of course we're open to any suggestions you may have.