search

nchudleigh / vimac

Productive macOS keyboard-driven navigation
https://vimacapp.com
GNU General Public License v3.0
3.43k stars 124 forks source link

[Bug] Shortcut activation is automatically reset to default bindings #470

Open MahdiNazemi opened 2 years ago

MahdiNazemi commented 2 years ago

I want to disable the activation of Vimac using the "Shortcut Activation" option. Therefore, I clear the default shortcuts to avoid collision with my existing shortcuts. However, the shortcuts are reset to their default values every once in a while without any notice. Is it possible to permanently disable the option?

tomdaly commented 2 years ago

bumping this with more info on behaviour; I have to manually clear the 'scroll shortcut' key every time I start Vimac because it clashes with a tmux shortcut.

it seems that other preferences are saved (like 'hold space to activate hint-mode' which I also disable), so the problem is not that the shortcuts are not saved - it is more that they are reset to the default if they are cleared.

I think this relates to this block of code: https://github.com/dexterleng/vimac/blob/master/ViMac-Swift/Bindings/KeyboardShortcuts.swift#L23-L25

a suggestion is to update it to check for 'shortcut manually cleared' (set to an unusable not nil value?), so that it doesn't reset to the default when the shortcut is nil

thanks @dexterleng for this tool!