~The Arranger upgrade seems to have updated the linter settings, triggering a bunch of new warnings (mostly for adding parentheses around individual params for functions, with some max line length related changes as well).~ EDIT: this was a false positive, after clearing node_modules and re-running yarn from the root, the linter reverted back to the previous state. I have reverted all linter changes as a result.
ES and Kibana upgrades done here via docker -- will obviously need to do something different for CBIIT. Have tested these versions on collab (as well as the mongo upgrade), no issues there. Locally, just the docker updates were enough. On collab it was more involved, I detailed what I did below.
Additionally, I have reached out to Cuong to see if he has any notes on doing the last ES upgrade for CBIIT HCMI.
🚨 DEPLOY INSTRUCTIONS 🚨
At this time, I'm unsure what the exact deploy instructions for CBIIT will be since I don't know how ES and Mongo are installed there. However, based on prior deploys to CBIIT and deploying this to Collab, I suspect it will be something like this:
Software upgrades and linter fixes!
~The Arranger upgrade seems to have updated the linter settings, triggering a bunch of new warnings (mostly for adding parentheses around individual params for functions, with some max line length related changes as well).~ EDIT: this was a false positive, after clearing node_modules and re-running yarn from the root, the linter reverted back to the previous state. I have reverted all linter changes as a result.
ES and Kibana upgrades done here via docker -- will obviously need to do something different for CBIIT. Have tested these versions on collab (as well as the mongo upgrade), no issues there. Locally, just the docker updates were enough. On collab it was more involved, I detailed what I did below.
Additionally, I have reached out to Cuong to see if he has any notes on doing the last ES upgrade for CBIIT HCMI.
🚨 DEPLOY INSTRUCTIONS 🚨
At this time, I'm unsure what the exact deploy instructions for CBIIT will be since I don't know how ES and Mongo are installed there. However, based on prior deploys to CBIIT and deploying this to Collab, I suspect it will be something like this:
rm -rf node_modules api/node_modules cms/node_modules data_model/node_modules ui/node_modulesCommits
⬆️ Upgrade Arranger to v2.19.1 (https://github.com/nci-hcmi-catalog/portal/issues/1001)
🚨 Fix Linter Warnings (https://github.com/nci-hcmi-catalog/portal/issues/1001)
Fixes numerous linter warnings that appeared after upgrading Arranger
Mostly just wrapping individual function inputs in parentheses
⬆️ Upgrade Elasticsearch to v7.17
Upgrade @elastic/elasticsearch to ~7.17.0 in root, api, cms, and data_mdoel
Upgrade elasticsearch and kibana docker images to 7.17.6
Revert "🚨 Fix Linter Warnings (https://github.com/nci-hcmi-catalog/portal/issues/1001)"