search

nci-hcmi-catalog / portal

HCMI Searchable Catalog Portal
https://hcmi-searchable-catalog.nci.nih.gov/
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

🐛 Correct Clinical Variant Validation #999

Closed mistryrn closed 2 years ago

mistryrn commented 2 years ago
mistryrn commented 2 years ago

Some backstory on this: while testing the variant change flagging in #998 , it was discovered that the validation of clinical variants wasn't working properly.

After some digging, it turns out it was related to the yup package upgrade (https://github.com/nci-hcmi-catalog/portal/commit/e71f2a1e81b871ab986b6ce9e428e71f013021cd).

In older versions of yup, plain objects would automatically be cast to strings when validating .string(). This is no longer the case, as per https://github.com/jquense/yup/issues/1200#issuecomment-752235685 . The solution in our case was to update the validation of clinical variants to check for objects of the correct structure.

joneubank commented 2 years ago

PR #999 😮