search

nci / scores

Metrics for the verification, evaluation and optimisation of forecasts, predictions or models.
https://scores.readthedocs.io/
Apache License 2.0
60 stars 15 forks source link

[JOSS] Lisence is not correctly specified #546

Closed savente93 closed 4 months ago

savente93 commented 4 months ago

This issue was files as part of my JOSS review for https://github.com/openjournals/joss-reviews/issues/6889.

While the project is licensed under the Apache License, Version 2.0, which is an OSI approved license, the license is only linked to, causing automated systems such as GitHub and the editorial bot to not recognize the license. Both in the interest of the authors work, the digital providence and automated license checking I'd like to see this rectified.

tennlee commented 4 months ago

Thank you for pointing this out, I will fix this.

tennlee commented 4 months ago

Hopefully I have now fixed this. I used the GitHub interface for the change, which means the develop branch is now updated and the repository itself now shows "Apache 2.0" for the license where it previously privded "Show license". Hopefully this means it is now done in standard fashion. If you are happy to confirm this looks right to you also, I would appreciate it.

The change will flow through to the main branch when we next prepare a release. If I have understood correctly, most tools/integrations rely on the license specified in the default branch. In our case that is the develop branch so I think it is all in order now.

tennlee commented 4 months ago

A quick note - the JOSS editorialbot is happy now and shows as green tick for the license.

savente93 commented 4 months ago

All good them :)