ncihtan / data-models

Schema.org Data Models for HTAN
MIT License
14 stars 7 forks source link

Integer valid values could be controlled by int::inRange #174

Open adamjtaylor opened 1 year ago

adamjtaylor commented 1 year ago

Could these values be better controlled with int::inRange

0,['Breast Cancer Allred Estrogen Receptor Score']
1,"['IRS Stage', 'Breast Cancer Allred Estrogen Receptor Score']"
10,['Breast Cancer Allred Estrogen Receptor Score']
2,"['IRS Stage', 'Breast Cancer Allred Estrogen Receptor Score']"
3,"['IRS Stage', 'Breast Cancer Allred Estrogen Receptor Score']"
4,"['IRS Stage', 'Breast Cancer Allred Estrogen Receptor Score']"
5,['Breast Cancer Allred Estrogen Receptor Score']
6,['Breast Cancer Allred Estrogen Receptor Score']
7,['Breast Cancer Allred Estrogen Receptor Score']
8,['Breast Cancer Allred Estrogen Receptor Score']
adamjtaylor commented 1 year ago

Not sure why 9 is not a valid value here.

adamjtaylor commented 1 year ago

Potential validation rules

adamjtaylor commented 1 year ago

See also quoted integers in #173

aclayton555 commented 1 year ago

Allred in breast cancer tier 3 - as of 2023.10.02 - no use of '10,' but 51 'unknown' and 0 null.

Agree to take no action.