Closed adamjtaylor closed 1 year ago
FYI @clarisse-lau many of these are like that you spotted in #253
Many of these fixes are due to differences in capitalization between the DependsOn entry and the Attributes. Suggest we harmonize based on the entry in the DependsOn.
@elv-sb just checking in on this?
@elv-sb thanks for looking into these. Let's discuss in our sprint close-out next week...I'm curious how some of these are happening. Anyway, I expect that efforts to tidy this will spill into our next sprint
Complete fixes in one giant PR in next sprint.
Are any attributes that are currently 'not used anywhere' - are any of these required? If so, this will cause a validation error.
Are there any attributes that will now have validation and trigger issues.
Check what has been submitted - MS - Stanford
@adamjtaylor could you please take a look at the ones below? I recommend removing them from the model
- [ ] Workflow Type - not used anywhere --> Required TRUE
- [ ] Workflow Parameters Description - not used anywhere --> Required TRUE
- [ ] Antigen Retrieval - not used anywhere - was removed from RFC Biospecimen Tier 2 --> Required FALSE
- [ ] Biospecimen Slide Location - not used anywhere - was removed from RFC Biospecimen Tier 1 --> Required FALSE
- [ ] Staining markers - not used anywhere - was removed from RFC Imaging Level 1 - v1 --> Required FALSE
- [ ] Age at Index - not used anywhere --> Required FALSE
- [ ] Anatomic Site - not used anywhere --> Required FALSE
@elv-sb happy for all of those to be removed from the model.
Found in initial development of some pre-commit hooks in #261
The following are entries in DependsOn that do not have a matching attribute
The following are attributes that appear to not be used by any component and may pair with one of the above: