search

ncihtan / data-models

Schema.org Data Models for HTAN
MIT License
14 stars 7 forks source link

Geomx Fixes Based on Internal Suggestions #283

Closed PozhidayevaDarya closed 1 year ago

PozhidayevaDarya commented 1 year ago

Closes: https://github.com/ncihtan/data-models/issues/281

adamjtaylor commented 1 year ago

@PozhidayevaDarya is this now ready to be merged? Potentially we could go to staging this week for you to test before going to prod in our end of august release.

PozhidayevaDarya commented 1 year ago

@adamjtaylor Yes, I think that's a great suggestion. Let's go ahead and add this to staging and shoot for prod end of august :) Thanks for all your help.

adamjtaylor commented 1 year ago

Thanks both! Unfortunately, I think there is now a blocker on the mtDCA end regarding implementing the configuration file for the staging instance that is going to prevent us from merging this until fixed. How urgent is this to get to staging?

PozhidayevaDarya commented 1 year ago

@adamjtaylor I would say this is fairly urgent since we want to test this with OHSU and they are on standby, however that being said we did not give them a hard date about when this would be available. How long with this take to fix?

adamjtaylor commented 1 year ago

@PozhidayevaDarya, I spoke to @afwillia about this and it is likely late August for the fix

clarisse-lau commented 1 year ago

It's urgent in that the staging link (currently missing some key components) has been shared with centers who have expressed willingness to test, but not in the sense of imminent GeoMx submissions.

Imo a late August resolution is ok, and gives @PozhidayevaDarya some time to make some additional fixes before proceeding with external testing. Does that sound ok?

PozhidayevaDarya commented 1 year ago

@clarisse-lau Yeap I'll let the centers know! Thank you both for your help on this