Incongruity between HTAN RFC doc/example and DCA template

alexeliotlash commented 8 months ago

Information

Proposed change:

Make changes to: (a) HTAN RFC document https://docs.google.com/document/d/1wQyVfj3TR36hg2E7OZDCIYv3p-Hm8DH_z73h1M3_hOM/edit, (b) RFC example https://docs.google.com/spreadsheets/d/1uKjwh8ENi5F9qiKab8r17Zgl_MtRWq70pfS8mauohD0/edit#gid=0, and/or (c) Synapse data model so that the former to and downloaded DCA template column headers match one another.

To highlight the differences in the above, I prepared a Google sheet comparing the column headers https://docs.google.com/spreadsheets/d/1Huy1jw7_7DeR2QlKOGUhpgJuUUg5i6LIuKiFK1_1bOY/edit#gid=0.

Discussion link:

Link to where the changes have been discussed/approved eg Closed RFC, Service desk ticket, DCC coordination/operations agenda

How important is this feature?

Select from the options below

🏝 Low - it's an enhancement but not crucial for work

When will use cases depending on this become relevant?

Select from the options below

Short-term - 2-4 weeks

Additional context

Add any other context or screenshots about the feature request here

Implementation checklist

[ ] Branch created
[ ] HTAN.model.csv editied and pushed
[ ] HTAN.model.jsonld validated and created by Github action
[ ] PR opened
[ ] PR approved
[ ] PR merged into main
[ ] New Component added to ncihtan/HTAN-data-curator (if required)
[ ] DCA update requested
[ ] DCA updated

aclayton555 commented 8 months ago

Issue seems to be that HTAN Publication ID is missing from the template in the DCA, and seems to be missing in the data model.

aclayton555 commented 8 months ago

Upon review, do not see any issues with attributes as is. Will not proceed with adding the HTAN Publication ID unless this is currently a blocker for submission. @alexeliotlash can you please confirm if you are NOT able to submit?

alexeliotlash commented 8 months ago

I will try to complete submission before the end of the day, but don't think this issue is a blocker. Perhaps the best way to approach the differences between RFC and DCA template would be to update the RFC to match the template--rather than change the data model.

alexeliotlash commented 8 months ago

DCA doesn't support entering ORCID URLs for multiple corresponding authors.

['https://orcid.org/0000-0001-8438-0319,https://orcid.org/0000-0002-2180-3844'] from row(s) [2] in column 'Corresponding Author ORCID': not conform to the standards of a URL. Please make sure you are entering a real, working URL as required by the Schema.

I'll submit it with a single corresponding author, but could you update the model in the meantime?

alexeliotlash commented 8 months ago

Alex made suggested changes to the RFC so that it corresponds to the current template. Adam will enter a DCA feature request so that a list of ORCID URLs will be accepted and validated.

aclayton555 commented 8 months ago

Re-opening to capture/track outstanding action to remove URL validation rule for 'Corresponding Author ORCID' for now.

Schematic feature request submitted to FAIR for validation of multiple URLs: https://sagebionetworks.jira.com/browse/IBCSPRT-223

ncihtan / data-models