search

ncihtan / data-models

Schema.org Data Models for HTAN
MIT License
14 stars 6 forks source link

Confirm valid values for DMR Calling Workflow URL #337

Closed adamjtaylor closed 4 months ago

adamjtaylor commented 6 months ago

It looks like DMR Calling Workflow URL currently has valid values Github, Synapse which don't seem to make sense. The description Generic name for the workflow used to analyze a data set also does not seem logical.

These are used by the Bulk Methylation-seq Level 3 component

Gibbsdavidl commented 5 months ago

Yes, I think that should probably read: "URL address for the workflow ..."

Gibbsdavidl commented 5 months ago

And the values should just be a string??

adamjtaylor commented 5 months ago

If I understand the intention the valid values should be removed and the url validation rule added (possibly with a warning condition rather than error)

aclayton555 commented 5 months ago

Bring for discussion on an Ops call with Dave

aclayton555 commented 5 months ago

Discussed on 2024.01.30 - Dave agrees this can be a URL. For reference, Adam will check what links have been included previously.

adamjtaylor commented 5 months ago

It looks like we have no Bulk Methylation Seq level 3 data submitted to date. We can therefore specify the URL validation rule without concern.