search

ncihtan / data-models

Schema.org Data Models for HTAN
MIT License
14 stars 6 forks source link

Add sf to file format #402

Closed adamjtaylor closed 1 month ago

adamjtaylor commented 1 month ago

Closes #399

adamjtaylor commented 1 month ago

Model integrity / Check attributes are unique fails:

"Panel Name" appears 2 times in the data model
"Total Number of Cells" appears 2 times in the data model
"Total Number of Targets" appears 2 times in the data model
"Experiment IF Channels" appears 2 times in the data model
"Transcripts per Cell" appears 2 times in the data model
"Percent of Transcripts within Cells" appears 2 times in the data model
"Panel Name" appears 2 times in the data model
"Total Number of Cells" appears 2 times in the data model
"Total Number of Targets" appears 2 times in the data model
"Experiment IF Channels" appears 2 times in the data model
"Transcripts per Cell" appears 2 times in the data model
"Percent of Transcripts within Cells" appears 2 times in the data model

I am guessing we didn't properly resolve conflicts when merging CosMX and Xenium.

adamjtaylor commented 1 month ago

We will address the model integrity failure in #402. OK to merge if the JSON-ld only shows a change in the added sf valid value