search

ncihtan / data-models

Schema.org Data Models for HTAN
MIT License
14 stars 6 forks source link

Update Node version in actions #414

Closed adamjtaylor closed 3 weeks ago

adamjtaylor commented 1 month ago 
Check attributes are unique
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check component requirements
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check attributes exist
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check attributes are used
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
aclayton555 commented 1 month ago

Consider pining these to run on latest, rather than a specific version. Also consider a better testing process (and backlog a ticket for this).

adamjtaylor commented 1 month ago

Better testing process can be covered in the existing #416

jmvera255 commented 3 weeks ago

I'm documenting all Node.js 16 warning for all GH action runs:

schema-bq.yml

ci-lint-validate-convert.yml

model-integrity-checks.yml

jmvera255 commented 3 weeks ago

Consider pining these to run on latest, rather than a specific version.

@adamjtaylor I did some reading at it sounds like actions need to be pinned either to a specific tag or a branch and it's up to the developers to create and maintain a "latest" branch/tag. I'm not seeing "latest" as a tag or branch either setup-python or checkout which makes me think I'm not likely to find "latest" for other actions list above.

For reference: https://github.com/marketplace/actions/latest-tag

I will move forward with updating actions to the latest available version tags