ncihtan / hdash_air

MIT License
0 stars 0 forks source link

SRRS Validation #2

Closed clarisse-lau closed 1 year ago

clarisse-lau commented 1 year ago

A couple of notes from review of SRRS hdash validation errors:

ecerami commented 1 year ago

@clarisse-lau I did the first part. SRRS now passes the demographics test. See: http://hdash.website-us-east-1.linodeobjects.com/HTA15.html.

The second part is more complicated, thinking on that one next.

ecerami commented 1 year ago

@clarisse-lau ok, I tried a fix for the second part, and I got the number of linking errors to go down from 338. But, I still see 209 linking errors. See: http://hdash.website-us-east-1.linodeobjects.com/HTA15.html. Do these look accurate? or is there somewhere else in SRRS I need to look?

ecerami commented 1 year ago

@clarisse-lau Actually I think these new validation errors are correct.

There are currently only 8 records specified in SRRSClinicalDataTier2.

And, this error: "HTA3_11009_15000001 references parent ID=HTA3_11009, but no such ID exist" appears to be correct.

So... I am going to close this issue and consider it fixed. If you find otherwise, just reopen. thanks.

clarisse-lau commented 1 year ago

Thanks @ecerami ! Yes, the remaining errors appear to be actual errors :)