ncihtan / htan-portal

The HTAN Data Portal
https://humantumoratlas.org
9 stars 11 forks source link

JSON Update Related Fixes #133

Closed inodb closed 3 years ago

inodb commented 3 years ago

@alisman @adamabeshouse @onursumer let's split these up at 2PM

schultzn commented 3 years ago

Here is some more feedback on names and displays.. looks great!!

onursumer commented 3 years ago
  • [ ] - does the filename column need to show the full path, or is filename sufficient?
  • [ ] - can the filename column be wider?

we have a separate issue for these ones: #129

  • [ ] - use a slightly larger font for the summary statistics on the files tab so that even the PIs can read it

oops, we thought we were targeting a younger user base :smile:

schultzn commented 3 years ago

oops, we thought we were targeting a younger user base 😄

I only commented on behalf of the older PIs... you can make the font size smaller for me.

onursumer commented 3 years ago

oops, we thought we were targeting a younger user base 😄

I only commented on behalf of the older PIs... you can make the font size smaller for me.

@schultzn https://htan-portal-ne-git-fork-onursumer-increase-summary-font-415aea.vercel.app/explore?tab=file. Could you confirm that this version is PI readable? I mean on behalf of the older PIs 😉

schultzn commented 3 years ago

better, yes! @onursumer

inodb commented 3 years ago

This is done