ncihtan / htan-portal

The HTAN Data Portal
https://humantumoratlas.org
10 stars 12 forks source link

✨New Feature: Treatment Filter #635

Closed SAHU-01 closed 5 months ago

SAHU-01 commented 6 months ago

Fixing #625

Describe changes proposed in this pull request:

Screenshot:

image

Notify reviewers: @onursumer

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
htan-portal-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 10:52pm
SAHU-01 commented 6 months ago

@onursumer I tried modifying the processSynapseJson.ts to include more treatment data but I'm not sure if this approach would work?

image
onursumer commented 6 months ago

@SAHU-01 I think a treatment list like this would work, but we may want to change the way we process the Therapy data in processSynapseJSON.ts. I'll add another comment/suggestion for that.

@onursumer I tried modifying the processSynapseJson.ts to include more treatment data but I'm not sure if this approach would work? image

inodb commented 6 months ago

@SAHU-01 great work! Would it be possible to move the Treatment column to the cases tab? We can still keep it as a file attribute, but maybe better not to show by default

SAHU-01 commented 6 months ago

@onursumer we can display Treatment column in case tab, I've set it up, by default it won't be visible in case tab, from the columns dropdown if treatment type is selected, the treatment type column will be visible. Like this:

image

Should I remove the treatment type column from file tab?

onursumer commented 6 months ago

@SAHU-01 I think we can make the new Treatment column visible by default for the Cases tab, and also keep it in the file tab but hide it there by default.

inodb commented 5 months ago

@SAHU-01 two minor tweaks that could be nice:

SAHU-01 commented 5 months ago

@inodb would this work?

image
inodb commented 5 months ago

@SAHU-01 perfect - thank you!