ncjoes / office-converter

PHP Wrapper for LibreOffice
MIT License
220 stars 78 forks source link

PHP-CS-Fixer and PHPStan #16

Closed KazuAlex closed 4 years ago

KazuAlex commented 4 years ago

I have an issue within my project and PHPStan that say to me :

Parameter #2 $tempPath of class NcJoes\OfficeConverter\OfficeConverter constructor expects null, string given.

Then, i decided to propose to run PHPStan (level 8) and PHP-CS-Fixer

PHPStan : https://github.com/phpstan/phpstan PHP-CS-Fixer : https://github.com/FriendsOfPHP/PHP-CS-Fixer

peter279k commented 4 years ago

This PR looks good, but I think we can also consider integrating one of CI build service to ensure the coding style check and static analysis check are executed on upcoming commits/PRs.

The available CI build services are as follows:

And I think the CI build service integration is another PR :).

KazuAlex commented 4 years ago

we can also consider integrating one of CI

I totally agree with that and i'll do that in another PR @ncjoes can you review this PR and merge it if you are ok ?

KazuAlex commented 4 years ago

I have sent an email to @ncjoes but no response. I think this repository is partially abandoned. So i have created a organization and forked this repo. I will transfer him if he wishes.

https://github.com/OfficeConverter/office-converter

peter279k commented 4 years ago

@KazuAlex, I hope the repository owner @ncjoes will come back to concern this :).

KazuAlex commented 4 years ago

I hope too ;)