search

nck-2 / test-rep

0 stars 0 forks source link

Further matching engine improvements #1365

Open githubmanticore opened 1 year ago

githubmanticore commented 1 year ago

Streamed hits code is now in 4gb-v2, but it needs some improvements:

  1. Need to benchmark subtree caching. Do we really need it?
  2. Need to benchmark class member vs stack variables (optimization present in 2.x, removed in 3.x as questionable).
githubmanticore commented 1 year ago

➤ Ilya Kuznetsov commented:

Regarding class members vs stack variables. This optimization still works, and its worth about 5% overall performance. Need to re-implement it.

githubmanticore commented 1 year ago

➤ Ilya Kuznetsov commented:

Benchmarks on hetzner servers show that stack var optimization still works. Reimplemented it in a537b16f

githubmanticore commented 1 year ago

➤ Ilya Kuznetsov commented:

With recent changes, 'new' 4gb-v2 is 7% slower than the 'old' 4gb-v2 running the use around query.

githubmanticore commented 1 year ago

➤ Ilya Kuznetsov commented:

Reverted max_block_docs to 512 in 0336d10f. Now 'new' 4gb-v2 is 4% slower than the 'old' 4gb-v2 running the use around query.

githubmanticore commented 1 year ago

➤ Ilya Kuznetsov commented:

Note: keywords query is 6% slower.

githubmanticore commented 1 year ago

➤ Ilya Kuznetsov commented:

All is done except subtree caching. It is commented out, need to benchmark it.