search

nckprsn / scrollme

A jQuery plugin for adding simple scrolling effects to web pages.
1.47k stars 318 forks source link

fix support for jQuery 3.0.0 and build tool to minify scrollme #35

Open dotnetCarpenter opened 8 years ago

dotnetCarpenter commented 8 years ago

This fixes #34

Tested in Chrome 50 and Firefox 47

This features a simple build tool (uglify2) - just run the command npm run build to get a minified version of jquery.scrollme.js. Based on npm, so there is now a package.json.

Other fixes include, pointing bower main to an unminified version per specification and only running the initialization code once.

The version has been bumped to version 1.1.1 - so all you need to do is git tag v1.1.1 -am "Support for jQuery3" && git push --tag

Cheers!

PS. We will run off our fork (https://github.com/Firefund/scrollme) until this is merged. My commit (c5ed23ab551ec18a5e7e3b41170e46ab837f2055) is signed with my public pgp key if you want to verify (github should already be doing this - if you look in the commit history) you can download my key from https://github.com/Firefund/frontend/blob/master/MAINTAINERS/dotnetCarpenter.asc

jonsuther commented 8 years ago

Thanks! Fixed my issue.

subhasisghosal commented 6 years ago

I've downloaded the version you fixed. But still it's not working. Do I have to copy any file other than jquery.scrollme.js? I'm using gulp to build the minification.

dotnetCarpenter commented 6 years ago

@subhasisghosal Not sure what error you are getting. So can't tell you. But no, you would normally not need anything else than https://github.com/Firefund/scrollme/blob/jquery3/jquery.scrollme.js.