Issues with jquery 3.1.1?

[acarlson777]

@nckprsn anyone having issues getting this to work with v.3.1.1? I'm acquiring the files just fine, but nothing is animating. I'm a little fresh to jquery so its possible I'm making some minor mistake in my html. I've required both the jquery library and the scroll me plugin in my head tag. And at the bottom of the body I have the $(function()){}); to load the script. But the div I have decked out with the data attributes wont animate. I have everything set to the same parameters that are applied to the Usage section on the demo page (the light gray code box on the right that fades and slides in from the right is exactly what I'm trying to emulate. If anyone might spare a minute to help an eager noob I'd greatly appreciate it. Thanks!

[ganimo]

I have the same problem. I think that is not compatible with jquery v.3.1.1. when I change to jquery v.2.1.1 work.

[joeyfromspace]

This is because scrollme uses $(window).load() which has been removed in jquery 3. It appears someone made a fork that addresses this here, though I've not tested the fix.

[subhasisghosal]

The fix is not working at all

[hicugi]

fixed:

replace on 123 // $window.load( function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) }); $(document).ready( function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) });

and on 447 // $document.on( _this.init_events.join( ' ' ) , function(){ _this.init(); } ); $('docuemnt').ready(function(){ _this.init(); });

[kylejcorrigan]

@hicugi fix works great! thanks!

[joekendal]

@hicugi have you tried making a PR?

[hicugi]

@joekendal PR? can you decipher?