nckprsn / scrollme

A jQuery plugin for adding simple scrolling effects to web pages.
1.47k stars 318 forks source link

Doesn't work with jquery 3.3.1 #54

Open okbanouri opened 6 years ago

okbanouri commented 6 years ago

I had to use older jquery version (2.1.3) to make it work.

bvrtsz commented 6 years ago

Still not working for me. Created fresh new HTML test with only jquery 3.3.1 (2.1.3 works fine) and scrollme.js but it didn't help. No console errors, but styles are not apllied etc.

joekendal commented 6 years ago

@bvrtsz If there are no console errors then it's probably not an issue with the jQuery version. Could you share a code snippet so we can see where the issue may be

bvrtsz commented 6 years ago

@joekendal I've tried jQuery 2.1.3 with the same code and it's working perfectly fine.

God, damn, I cant upload my ocde here, just a minute.

https://codepen.io/anon/pen/LJEPVr

That's how my HTML looks like. Nothing fancy, just want to move the smaller square around.

I've got a "test" folder with html and scrollme.js

joekendal commented 6 years ago

@bvrtsz forked your code https://codepen.io/anon/pen/gdbYqP working

andrey-prokhorov commented 6 years ago

@joekendal I forked https://codepen.io/anon/pen/gdbYqP and if you take latest verson from github "jquery.scrollme.min.js" - it stops working 😕

Strange that author does not put a version in the js file 😃

See example: https://codepen.io/andreyprokhorov/pen/pQZBYV The diff: https://www.diffchecker.com/BmvCZpTM

jasperuitterhoeve commented 4 years ago

Is there a fix for this? I am having the exact same issue.

sezaialkan commented 1 year ago

Jquery 3.6.2

line 123 and $window.on('load', function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) }); $(document).ready( function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) });

change lines 447 $document.on( _this.init_events.join( ' ' ) , function(){ _this.init(); } ); $('document').ready(function(){ _this.init(); });

joekendal commented 1 year ago

Bro no one still uses jquery do they