search

ncl-ROVers / surface-2019-20

High-level ROV
MIT License
4 stars 8 forks source link

Fix verbose log formatting #76

Closed TheCodeSummoner closed 4 years ago

TheCodeSummoner commented 4 years ago

The spacing still has issues, despite my efforts to make all lines even. I can add an example later if you can't run the code.

AndMcL commented 4 years ago

An example would be good thanks

TheCodeSummoner commented 4 years ago 
20-01-10 15:49:33 INFO     | MainProcess    27436 | src\common\data_manager.py     __init__        70 | Successfully created shared memory "transmission" with a total of 8 keys
20-01-10 15:49:33 INFO     | MainProcess    27436 | src\common\data_manager.py     __init__        70 | Successfully created shared memory "control" with a total of 13 keys
20-01-10 15:49:34 INFO     | MainProcess    27436 | src\control\manual.py          start          450 | Controller reading process started, pid 18252
20-01-10 15:49:34 INFO     | MainProcess    27436 | src\control\model.py           start          375 | Control manager process started, pid 23560
20-01-10 15:49:35 DEBUG    |  Process-2    23560 | src\control\model.py           _pull           91 | Pulling data for the control model
20-01-10 15:49:35 DEBUG    |  Process-2    23560 | src\common\data_manager.py     get_all        121 | Getting all data from control shared memory
20-01-10 15:49:35 DEBUG    | MainProcess    27436 | src\gui\utils.py               on_exit        322 | Switched out of Loading
20-01-10 15:49:35 DEBUG    |  Process-2    23560 | src\control\model.py           _merge         113 | Merging control model data
20-01-10 15:49:35 DEBUG    | MainProcess    27436 | src\gui\utils.py               on_switch      314 | Switched screen to Loading

I would like the | characters to be aligned. Unfortunately, I couldn't group up multiple items when formatting (e.g. {processName:>10} {process:8} instead of {({processName}:{process}):25} - I wish I could make them take X characters of space together).

You can always run the code if you disable the controller initialisation in __main__.py to see the GUI.

jtwil commented 4 years ago

@TheCodeSummoner Could you try the change above? We couldn't find a way to group up multiple items, but these changes at least make the logging align in the testing we did.

TheCodeSummoner commented 4 years ago

Looks good to me, merged with master