nclarius / tile-gaps

KWin script to add space around windows touching a screen edge or other window
https://store.kde.org/p/1619642
GNU General Public License v3.0
108 stars 16 forks source link

Floating Panel support not working #22

Open jj-sallo opened 1 year ago

jj-sallo commented 1 year ago

Description

The Floating Panel checkbox should enable the script to add gaps between windows and floating panels, but it doesn't.

System Details

Steps to reproduce

  1. Enable the floating panel option in the script settings on a side with a floating panel, and the Gaps on Maximized Windows option.
  2. Restart the script

image

Expected behavior

There should be a gap between the window and the floating panel.

Actual behavior

There is no gap between the panel and the window.

image

Additional info

It actually works without the check enabled.

image

image

However, some applications trigger expansion of the floating panel on maximized window, where before, with the Floating Panel check enabled in the script options, they didn't.

So far, I have found that KDE applications and Firefox do not trigger this behavior, but apps such as MS Edge and Flatseal do.

image

image

I have found increasing the edge size to be a workaround for some applications, but it doesn't work for all of them.

Earthling-Z3R0 commented 1 year ago

Same issue here. Ive been using this KWin script for a long time and just love it! The recent plasma 5.27 update broke it for me in a certain way.

I am using Breeze theme. I am using a 40 pixel floating panel (top). I am using 10 pixel gaps on all sides. I am using 10 pixel gaps on maximized windows.

Since the plasma 5.27 update maximizing a window will remove all gaps and make it touch the panel which will become non-floating. The panel will now look like a maximized panel but become larger in size (48 pixels instead of 40 pixels in my case).

Un-maximizing the window will bring gaps back and also make the panel floating again with correct size (40 pixels for me).

The issue seems to trigger when maximizing a window.

I tried using a maximized panel (i.e. not floating) but the same issue applies. The maximized window will lose all gaps (but the panel will keep correct size of 40 pixels for me).

screenshot_2023-02-18_10-57-13

nclarius commented 1 year ago

Thanks for the report, I'll look into it.

Peter-Ries commented 1 year ago

Same here. I thought I should blame Wayland for it, but it seems to affect X11 as well.

But no updates for 9 months. Is the project dead?