search

nclient / NClient

:dizzy: NClient is an automatic type-safe .Net HTTP client that allows you to call web service API methods using annotated interfaces or controllers without boilerplate code.
Apache License 2.0
43 stars 11 forks source link

Testing serializer source generator #429

Closed smolchanovsky closed 2 years ago

smolchanovsky commented 2 years ago

Added tests checking serializer source generator.

Kingmidas74 commented 2 years ago

Can you give a little summary for experiments? Would this modifications increase perf or other advantages? As I understood, our users should be created their-own DTOs which inherit from SourceContextGenerator (or smth), aren't? Do you thinks it's worth it?

smolchanovsky commented 2 years ago

I think for PR about perf we should provide any proofs of advantages.

Benchmarks are needed for internal use to monitor how performance changes

Kingmidas74 commented 2 years ago

I think for PR about perf we should provide any proofs of advantages.

Benchmarks are needed for internal use to monitor how performance changes

So.... Does performance has been changed?

smolchanovsky commented 2 years ago

Can you give a little summary for experiments? Would this modifications increase perf or other advantages? As I understood, our users should be created their-own DTOs which inherit from SourceContextGenerator (or smth), aren't? Do you thinks it's worth it?

So.... Does performance has been changed?

I answer both questions. The performance is improving, but only slightly. The fact is that compared to other operations, serialization takes a small part of the time. For understanding, serialization is measured in nanoseconds, and all client operations in tens of microseconds.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication