Clientvalidatorfixes - Githubissues

nclient / NClient

:dizzy: NClient is an automatic type-safe .Net HTTP client that allows you to call web service API methods using annotated interfaces or controllers without boilerplate code.

Apache License 2.0

43 stars 11 forks source link

Clientvalidatorfixes #459

Closed reaver330 closed 1 year ago

reaver330 commented 2 years ago

This small change became somewhat large as time went by and things were uncovered :)

Fixed the validation bug where parameters for a method on an interface supplied to NClient were provided in the annotation but not included in the actual declaration. The validation code now detects this scenario and throws the relevant exception.
In order to achieve this the execution pipeline needed a way to gracefully exit if an error was encountered during processing, so a new IPipelineCanceller interface and a basic implementation of it in PipelineCanceller were added, that use CancellationToken under the hood.
Added generic params to the validation Stubs
Moved clientInterceptorFactory creation to the ctor of the ClientValidator
Added validation code to skip 'hidden' methods on interfaces, added the tests for it
Corrected 3 net48 compiler errors

smolchanovsky commented 2 years ago

@reaver330 thanks for the pull request! I need time for a review, I think I'll do it this weekend

reaver330 commented 2 years ago

@smolchanovsky its my pleasure! Thanks for the advice on the other PR 👍.

reaver330 commented 2 years ago

Thanks @smolchanovsky, I am studying this week (and maybe next) but will get to this after

reaver330 commented 2 years ago

Hi @smolchanovsky, sorry for the delays I was studying and then a week on holiday. I have updated and pushed the changes. Please let me know if there is more that requires attention. Cheers 👍

reaver330 commented 1 year ago

Hi @smolchanovsky, welcome back! That was a long break, i hope everything is ok?

I have added some code so that the _pipelineCanceller is initialised like this: _pipelineCanceler = default!;

My build was passing locally and all the tests were passing; so I'm curious what the circumstances were that your build picked up this problem?

smolchanovsky commented 1 year ago

Hi @smolchanovsky, welcome back! That was a long break, i hope everything is ok?

I have added some code so that the _pipelineCanceller is initialised like this: _pipelineCanceler = default!;

My build was passing locally and all the tests were passing; so I'm curious what the circumstances were that your build picked up this problem?

Thank you, everything is ok :) however, I had to move to another country

About the failed build: ci/cd of the project uses a zero tolerance policy for warnings. So build is run with warnaserror option: dotnet build /warnaserror

smolchanovsky commented 1 year ago

@reaver330 all tests were successful, the pull request is merged, thank you!

Now you are the contributor of NClient :)