nclskfm / square-core

SQuARE: Software for question answering research.

https://square.ukp-lab.de

2 stars 0 forks source link

Add CRUD endpoints for dataset metadata #58

Closed nclskfm closed 1 year ago

nclskfm commented 1 year ago

What does this PR do?

7

Add CRUD endpoints
Add auth
Update DatasetFormatter to use the dataset mappings
Remove mocked get_dataset_mapping function
Add DatasetHandler to download/delete datasets as background task
Add comments
Add logging

Todo:

[x] Add logging
[x] Add comments
[x] Replace mocked get_dataset_mapping function
[x] Add auth check for admins
[x] Call Datasethandler

nclskfm commented 1 year ago

Code suggestions / Bug fixes:

choices_key_mapping_column is optional
GET /datasets return whole dataset objects instead of the names only
Moved validate_dataset_name
Changed access validation to be case-insensitive
Fix predict task