search

nclud / 2013.beercamp.com

MIT License
0 stars 1 forks source link

End game screen should display time (if you blacked out) #40

Closed peakpg closed 11 years ago

peakpg commented 11 years ago

When a player gets their character to blackout, the end game screen should display the amount of time it took them to accomplish that. I don't recall if the design called for showing the 3m's on the 'failure' game over screens or not, but if they did they should be updated to reflect that.

ksung commented 11 years ago

The only design with a time was the blackout one. Mike said he could include the gameplayed time since it needs to be server based. Once I have that I can add it to the blackout gameover screen.

peakpg commented 11 years ago

Gameplay time is currently calculated on the client so far as I know, so it should be accessible here: https://github.com/mikemorris/beercamp/blob/master/game/client/client.js on line 74

ksung commented 11 years ago

Mike said something to me about the date.now difference between server and client.

mikemorris commented 11 years ago

End time currently calculated on client but really should be handled on the server. In any case, the final end time should be computed once and passed to the end game function to ensure consistency.

mikemorris commented 11 years ago

depends on #49

mikemorris commented 11 years ago

added time to blackout screen in eab1da2a20ee5473bf860d22606cbccde9df5f93 and fixed some minor CSS issues (character sprites being cropped)