auto cleanup the plugin process when it's not needed

ncm2 / ncm2-jedi

MIT License

23 stars 11 forks source link

Open roxma opened 6 years ago

roxma commented 6 years ago

partounian commented 6 years ago

I'm not able to replicate roxma/nvim-completion-manager#62, I tried to replicate it by removing the lines

# jedi doesn't work on comment
# https://github.com/roxma/nvim-completion-manager/issues/62
if typed.find('#') != -1:
    return

I used htop on my macOS version 10.13.5 and searched for jedi while looking at overall ram usage and it seemed to be the same.

python 3.7.0 nvim 0.3.0 ncm2 6e0dabf ncm2-jedi 96f7658 jedi 0.12.1

Also haven't seen roxma/nvim-completion-manager#215 , I wonder if it's Windows specific?

Any more information would be lovely 😄

roxma commented 6 years ago

The memory issue is probably related to older python's memory leak. https://www.python.org/dev/peps/pep-0442/

It is hard to reproduce and I haven't come across this issue for a long tmie.

Let's wait for more report on this issue before pushing changes.

partounian commented 6 years ago

Thoughts on deleting those lines and seeing if anyone has an issue with it?

roxma commented 6 years ago

hmm... I'm ok with thoes lines, they don't break anything yet.

partounian commented 6 years ago

Okay with removing, or you want to leave them in?

roxma commented 6 years ago

I think it's fine to keep them.

roxma commented 5 years ago