ncmathan / pe

0 stars 0 forks source link

Allows invalid NRIC to be input #2

Open ncmathan opened 10 months ago

ncmathan commented 10 months ago

The app only checks for the regex of the NRIC, it does not calculate the checksum to check if the NRIC is valid

image.png

image.png

You can refer to nric.biz for the validation check

soc-se-bot commented 10 months ago

Team's Response

Thanks for bringing this up, unfortunately we feel that the validation regex can be different for different countries and currently our validation check simply checks for that regex format. We feel as ED doctor, they simply fill in the IC number given to them and we feel there is not as much as a need to check for accuracy of IC format to the extent of checking checksum.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The argument that "validation regex can be different for different countries" is invalid as the regex currently is set for Singapore issued IC numbers. There is still a need to check the checksum, as there is a possibility that ED doctor copies the IC number wrongly and the system has to be robust enough to detect that as well.