ncmathan / pe

0 stars 0 forks source link

Text not wrapped when displaying long names #7

Open ncmathan opened 10 months ago

ncmathan commented 10 months ago

When adding a patient with long enough valid name, the text is not wrapped and instead shows ellipses.

image.png

nus-se-script commented 10 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to view patients' full name when their names are too long

Unable to view patients' full names when their names are too long, and become abbreviated by "..." in both the list and the details part

image.png


[original: nus-cs2103-AY2324S1/pe-interim#3683] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for raising this issue! We agree that not being able to view a patient's full name (if their name is rather long) might be an issue. However, we believe that it is sufficient to be able to view most of the name in either one of the panels (the Patient List Panel or the Patient Record Panel), and you can adjust the width of either panel by dragging the divider between the two panels left or right to resize. Moreover, we also feel that it is highly unlikely for a name to be so long that it cannot be fully viewed when either one of the panels is maximized.

As screen real estate is limited, it is difficult to allow the user to have a full view of a long name without affecting other parts of the display (which might cause even more inconvenience for the user), which is why we decided to limit the space that the name takes up in the UI. This inevitably causes unusually long names to be truncated. Furthermore, a patient's full name is not completely necessary for identification purposes (IC number is also available), and therefore, not viewing the complete name might not cause too big of an issue to the user.

Nonetheless, having some other means to view the complete name can be helpful, but it is a non-essential enhancement that we believe can be worked on in the future. :)

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** This issue is clearly at least a cosmetic issue which cannot be ignored. This is especially troublesome if the given name of patient is at the end and the surname is in front and really long. Not knowing the patient's given name might cause issues when referring to the patient. ![image.png](https://raw.githubusercontent.com/ncmathan/pe/main/files/963cd92e-bb58-4137-8bdf-ed3a5e871ed0.png)