Open ncmathan opened 12 months ago
Thanks for bringing this up! We did indeed notice this issue before but we felt that it is not important to fix and decided to leave it as is, because we were not planning to restrict our product to only Singapore, and other countries could have different restrictions for phone numbers.
Team chose [response.NotInScope
]
Reason for disagreement: This argument is invalid because if the product was planned not to be restricted to Singapore's context, other parameters such as IC should allow for ICs from other countries which are of a different format as well.
And even if the product is meant for other countries the maximum length should still be restricted to the longest valid phone number globally.
There is no upper bound set for the length of the contact number. For singapore's context length should be exactly 8 digits.