search

ncmpcpp / ncmpcpp

Featureful ncurses based MPD client inspired by ncmpc
GNU General Public License v2.0
2.12k stars 225 forks source link

Broken lyrics fetcher for genius.com #487

Closed ian-s-mcb closed 3 years ago

ian-s-mcb commented 3 years ago

Describe the bug The lyrics fetcher for genius.com doesn't display any lyrics (or error message) for any song I've tried.

To Reproduce Steps to reproduce the behavior:

  1. Set lyrics fetcher to genius.com
  2. Play any mainstream song (eg. Coldplay - "The Scientist")
  3. Press show lyrics command

At this point, ncmpcpp will display an blank screen and no error message. I noticed a lyrics .txt file is created by ncmpcpp for the the song but the file is empty. For comparison, the fetcher for azlyrics.com works fine for the same songs that didn't work for genius.com.

Expected behavior Lyrics, or at the very least an error messge, are shown.

Desktop (please complete the following information):

arybczak commented 3 years ago

Can you try master? It should work there.

ian-s-mcb commented 3 years ago

@arybczak Works like a charm. Thank you!

I really dig ncmpcpp. You've done a great job with it.

dvzrv commented 2 years ago

@arybczak a new release would be much appreciated :tada: The latest version is from early 2021, so it does not have any fixes you might have applied and users of ncmpcpp in downstream distributions will still suffer from this issue.