nco / pynco

Python bindings for NCO
http://pynco.readthedocs.org
MIT License
91 stars 32 forks source link

Source tarball on PyPI is missing tests/conftest.py #80

Open matrss opened 3 months ago

matrss commented 3 months ago

The source tarball for the latest version 1.1.2 (but also for previous versions) does contain tests/test_nco.py and tests/test_nco_examples.py, but not tests/conftest.py. This makes the tests unusable, since required fixtures defined in conftest.py are missing. I am not sure if there might be other necessary files missing as well.

czender commented 3 months ago

As a temporary workaround you can grap the source tarball from GitHub, which does contain conftest.py:

zender@spectral:~/Downloads$ tar tvzf pynco-1.1.2.tar.gz 
drwxrwxr-x  0 root   root        0 Dec 20 10:32 pynco-1.1.2/
drwxrwxr-x  0 root   root        0 Dec 20 10:32 pynco-1.1.2/.github/
drwxrwxr-x  0 root   root        0 Dec 20 10:32 pynco-1.1.2/.github/workflows/
-rw-rw-r--  0 root   root     1015 Dec 20 10:32 pynco-1.1.2/.github/workflows/ci.yaml
-rw-rw-r--  0 root   root     1731 Dec 20 10:32 pynco-1.1.2/.github/workflows/publish-to-pypi.yaml
-rw-rw-r--  0 root   root      352 Dec 20 10:32 pynco-1.1.2/.gitignore
-rw-rw-r--  0 root   root      165 Dec 20 10:32 pynco-1.1.2/.readthedocs.yaml
-rw-rw-r--  0 root   root     1072 Dec 20 10:32 pynco-1.1.2/LICENSE.txt
-rw-rw-r--  0 root   root     1345 Dec 20 10:32 pynco-1.1.2/README.md
drwxrwxr-x  0 root   root        0 Dec 20 10:32 pynco-1.1.2/ci/
-rw-rw-r--  0 root   root      128 Dec 20 10:32 pynco-1.1.2/ci/requirements-3.10.yml
-rw-rw-r--  0 root   root      128 Dec 20 10:32 pynco-1.1.2/ci/requirements-3.11.yml
-rw-rw-r--  0 root   root      128 Dec 20 10:32 pynco-1.1.2/ci/requirements-3.12.yml
-rw-rw-r--  0 root   root      127 Dec 20 10:32 pynco-1.1.2/ci/requirements-3.8.yml
-rw-rw-r--  0 root   root      127 Dec 20 10:32 pynco-1.1.2/ci/requirements-3.9.yml
drwxrwxr-x  0 root   root        0 Dec 20 10:32 pynco-1.1.2/docs/
-rw-rw-r--  0 root   root     7630 Dec 20 10:32 pynco-1.1.2/docs/index.md
-rw-rw-r--  0 root   root       14 Dec 20 10:32 pynco-1.1.2/docs/requirements.txt
-rw-rw-r--  0 root   root      284 Dec 20 10:32 pynco-1.1.2/mkdocs.yml
drwxrwxr-x  0 root   root        0 Dec 20 10:32 pynco-1.1.2/nco/
-rw-rw-r--  0 root   root       35 Dec 20 10:32 pynco-1.1.2/nco/__init__.py
-rw-rw-r--  0 root   root    10805 Dec 20 10:32 pynco-1.1.2/nco/custom.py
-rw-rw-r--  0 root   root    19363 Dec 20 10:32 pynco-1.1.2/nco/nco.py
-rw-rw-r--  0 root   root       95 Dec 20 10:32 pynco-1.1.2/pyproject.toml
-rw-rw-r--  0 root   root     1058 Dec 20 10:32 pynco-1.1.2/setup.cfg
drwxrwxr-x  0 root   root        0 Dec 20 10:32 pynco-1.1.2/tests/
-rw-rw-r--  0 root   root        0 Dec 20 10:32 pynco-1.1.2/tests/__init__.py
-rw-rw-r--  0 root   root     8319 Dec 20 10:32 pynco-1.1.2/tests/conftest.py
-rw-rw-r--  0 root   root    10786 Dec 20 10:32 pynco-1.1.2/tests/test_nco.py
-rw-rw-r--  0 root   root     8274 Dec 20 10:32 pynco-1.1.2/tests/test_nco_examples.py
zender@spectral:~/Downloads$ 

Not sure why PyPi does not contain conftest.py, will look into it...

matrss commented 3 months ago

Yes, that is what I am doing here now: https://github.com/NixOS/nixpkgs/pull/319585 (I needed to package pynco in nixpkgs, as a dependency of MSS). So no urgency or anything, just wanted to make you aware of the issue.