Closed palaviv closed 8 years ago
Reviewing this for the second time, I realised there's a related bug in the current all_paths
implementation: it misses directory symlinks when run over a walk that doesn't follow symlinks and doesn't use the new filter. Filed as https://github.com/ncoghlan/walkdir/issues/3
(Amusingly, I'd forgotten the origins of the RFE I filed against walkdir about being able to report dirsymlinks as files, and had to be reminded by way of this Stack Overflow answer and the linked python-dev thread)
Closing this as per the discussion on #5 - the fact that symlinks to directories were omitted by dir_paths
and all_paths
when followlinks
was false in the underlying walk is now being treated as a bug in the implementation of those functions.
Same as https://bitbucket.org/ncoghlan/walkdir/pull-requests/1/dirsymlink/ with small changes to the tests.